fix(frontend): enhance yaml editor completions#2139
Merged
Conversation
yassinedorbozgithub
force-pushed
the
fix/frontend-enhance-yaml-editor-completions
branch
from
July 17, 2026 12:51
0b6dc81 to
10e98e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the custom YAML completion provider with generic schema-driven completion based on
WORKFLOW_YAML_SCHEMA, backend action/binding schemas, and live workflow definitions. Also removed obsolete completion state and fixed clipped Monaco completion details.Why
Completions must adapt automatically to selected actions, binding kinds, available definition references, and workflow tasks without maintaining key-specific completion logic.
How to review
Focus on:
completion.ts: dynamic schema augmentation and filtering.language.ts: Monaco YAML schema updates.useYamlEditorController.ts: action, binding, and live definition integration.flow.do, and incomplete YAML.taskIdsstate.Validation
git diff --checkpassed.