Skip to content

fix(frontend): enhance yaml editor completions#2139

Merged
marrouchi merged 1 commit into
mainfrom
fix/frontend-enhance-yaml-editor-completions
Jul 17, 2026
Merged

fix(frontend): enhance yaml editor completions#2139
marrouchi merged 1 commit into
mainfrom
fix/frontend-enhance-yaml-editor-completions

Conversation

@yassinedorbozgithub

Copy link
Copy Markdown
Collaborator

Summary

Replaced the custom YAML completion provider with generic schema-driven completion based on WORKFLOW_YAML_SCHEMA, backend action/binding schemas, and live workflow definitions. Also removed obsolete completion state and fixed clipped Monaco completion details.

Why

Completions must adapt automatically to selected actions, binding kinds, available definition references, and workflow tasks without maintaining key-specific completion logic.

How to review

Focus on:

  • completion.ts: dynamic schema augmentation and filtering.
  • language.ts: Monaco YAML schema updates.
  • useYamlEditorController.ts: action, binding, and live definition integration.
  • Completion coverage for action inputs/settings, binding settings/references, flow.do, and incomplete YAML.
  • Removal of the old custom provider, completion types, and unused taskIds state.

Validation

  • Frontend tests: 224 passed.
  • TypeScript typecheck passed.
  • ESLint passed for touched files.
  • Production build passed.
  • git diff --check passed.

@yassinedorbozgithub
yassinedorbozgithub force-pushed the fix/frontend-enhance-yaml-editor-completions branch from 0b6dc81 to 10e98e1 Compare July 17, 2026 12:51
@marrouchi
marrouchi merged commit 6de41b3 into main Jul 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants